Allow users to pick local audio source location #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
context.getExternalFilesDir(null) will default to what it believes is the primary storage, sometimes that's internal and sometimes that's external. With this change users will now be able to pick which option they want. If the user does nothing it defaults back to the existing getExternalFilesDir and allows the system to pick the default.
KamWithK
requested changes
Apr 6, 2025
app/src/main/java/com/kamwithk/ankiconnectandroid/routing/LocalAudioAPIRouting.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/kamwithk/ankiconnectandroid/SettingsActivity.java
Outdated
Show resolved
Hide resolved
This change makes the code a lot cleaner, relying on the default shared preferences instead of trying to sync new ones.
ellieglad
changed the title
KamWithK
requested changes
Aug 21, 2025
app/src/main/java/com/kamwithk/ankiconnectandroid/SettingsActivity.java
Outdated
Show resolved
Hide resolved
|
@ellieglad would you be able to rebase the latest changes into your branch? |
|
@KamWithK done. github's sync fork option only allows for merging not rebasing unfortunately. |
Hey so someone tried this PR for me, but they weren't able to choose a folder Are you on Discord by any chance, it'd be easier to problem solve/discuss in messages Discussions on TheMoeWay or DMs both work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context.getExternalFilesDir(null)will default to what it believes is the primary storage, sometimes that's internal and sometimes that's external. With this change users will now be able to pick which option they want. If the user does nothing it defaults back to the existinggetExternalFilesDirand allows the system to pick the default.The new option shown here under "Choose local audio directory location".
Open to any changes or feel free to close if it's believed that this will not add value.
Thanks!